Skip to content

[Sync] Update project files from source repository (ffbafef)#116

Merged
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bsv-blockchain-sdks-20260320-120447-ffbafef
Mar 20, 2026
Merged

[Sync] Update project files from source repository (ffbafef)#116
mrz1836 merged 1 commit intomasterfrom
chore/sync-files-bsv-blockchain-sdks-20260320-120447-ffbafef

Conversation

@mrz1836
Copy link
Copy Markdown
Collaborator

@mrz1836 mrz1836 commented Mar 20, 2026

What Changed

  • Updated minimum Go version requirement for benchstat from 1.23 to 1.25 throughout .github/actions/setup-benchstat/action.yml
  • Modified version check logic to compare against 1.25 instead of 1.23 (changed condition from [ "$MINOR" -lt 23 ] to [ "$MINOR" -lt 25 ])
  • Updated input descriptions, output descriptions, comments, and user-facing messages to reflect the new 1.25+ requirement
  • Changed example Go versions in documentation from "1.24.x, 1.22" to "1.25.x, 1.24" and error message examples from "1.23, 1.24.x" to "1.25, 1.26.x"

Why It Was Necessary

  • Benchstat tool now requires a newer version of Go (1.25+) to function properly
  • Prevents installation attempts on incompatible Go versions that would fail
  • Ensures users are informed early in the workflow if their Go version is insufficient

Testing Performed

  • Verify the version check logic correctly parses and compares Go versions against the new 1.25 threshold
  • Test that workflows using Go 1.24 or earlier properly skip benchstat installation with appropriate warning messages
  • Confirm workflows using Go 1.25+ proceed with benchstat installation as expected

Impact / Risk

  • Breaking Change: Workflows using Go versions 1.23 or 1.24 will now skip benchstat installation (previously these versions were supported)
  • Risk: Low - the action gracefully skips installation with clear messaging rather than failing; existing workflows on older Go versions will continue to run but without benchstat
  • Migration: Teams using Go 1.23-1.24 must upgrade to Go 1.25+ to continue using benchstat functionality

@mrz1836 mrz1836 self-assigned this Mar 20, 2026
@mrz1836 mrz1836 added automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps labels Mar 20, 2026
@github-actions github-actions bot added update General updates size/M Medium change (51–200 lines) labels Mar 20, 2026
@sonarqubecloud
Copy link
Copy Markdown

@mrz1836
Copy link
Copy Markdown
Collaborator Author

mrz1836 commented Mar 20, 2026

LGTM!

@mrz1836 mrz1836 merged commit 1ad21a0 into master Mar 20, 2026
44 checks passed
@github-actions github-actions bot deleted the chore/sync-files-bsv-blockchain-sdks-20260320-120447-ffbafef branch March 20, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-sync Automated sync PR, e.g. from a fork or external repo automerge Label to automatically merge pull requests that meet all required conditions chore Simple dependency updates or version bumps size/M Medium change (51–200 lines) update General updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant